Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect pathmapper name conflicts. #805

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Detect pathmapper name conflicts. #805

wants to merge 9 commits into from

Conversation

tetron
Copy link
Member

@tetron tetron commented Jul 1, 2018

No description provided.

@codecov
Copy link

codecov bot commented Jul 1, 2018 •
edited
Loading

Codecov Report

Merging #805 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #805      +/-   ##
==========================================
- Coverage   68.69%   68.69%   -0.01%     
==========================================
  Files          33       33              
  Lines        5300     5306       +6     
  Branches     1408     1411       +3     
==========================================
+ Hits         3641     3645       +4     
- Misses       1293     1294       +1     
- Partials      366      367       +1
Impacted Files Coverage Δ
cwltool/pathmapper.py 87.23% <100%> (+0.42%) ⬆️
cwltool/executors.py 70.27% <0%> (-2.71%) ⬇️
cwltool/workflow.py 81.3% <0%> (-0.37%) ⬇️
cwltool/main.py 38.77% <0%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 639229b...e272a28. Read the comment docs.

@mr-c
Copy link
Member

mr-c commented Jul 1, 2018

Some conformance tests are failing

Test [111/132] Test that nameroot and nameext are generated from basename at execution time by the runner

Test failed: /home/jenkins/workspace/cwltool-pr-conformance-multiver/version/v1.0/cwltool_with_cov --outdir=/tmp/tmp2O_5aD --quiet v1.0/basename-fields-test.cwl v1.0/basename-fields-job.yml
Test that nameroot and nameext are generated from basename at execution time by the runner
Returned non-zero
Workflow checker warning:
v1.0/basename-fields-test.cwl:22:7: 'tool' is not an input parameter of
                                    file:///home/jenkins/workspace/cwltool-pr-conformance-multiver/version/v1.0/common-workflow-language-master/v1.0/v1.0/echo-file-tool.cwl,
                                    expected in
v1.0/basename-fields-test.cwl:29:7: 'tool' is not an input parameter of
                                    file:///home/jenkins/workspace/cwltool-pr-conformance-multiver/version/v1.0/common-workflow-language-master/v1.0/v1.0/echo-file-tool.cwl,
                                    expected in
Input object failed validation:
Name conflict: both file:///tmp/tmp2iFvx1/d89b855ec592203974172af5cae00aa5dc04ce78 and file:///tmp/tmpUTsh9f/d89b855ec592203974172af5cae00aa5dc04ce78 have been assigned to target /tmp/tmp2O_5aD/d89b855ec592203974172af5cae00aa5dc04ce78

@mr-c mr-c changed the base branch from master to main July 2, 2020 11:09
@mr-c mr-c marked this pull request as draft December 3, 2020 17:43
@mr-c mr-c force-pushed the name-conflict-error branch from 0470ebf to c1226c1 Compare September 5, 2021 13:49
@mr-c mr-c force-pushed the name-conflict-error branch from c1226c1 to 476952d Compare September 6, 2021 12:25
@tetron
Copy link
Member Author

tetron commented May 5, 2022

It seems like the main reason this hasn't been merged is this failing conformance test....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tetron @mr-c